Skip to content

Comments

added in getPersonsProjects#34

Open
Jameron wants to merge 3 commits intonetvlies:masterfrom
Jameron:master
Open

added in getPersonsProjects#34
Jameron wants to merge 3 commits intonetvlies:masterfrom
Jameron:master

Conversation

@Jameron
Copy link

@Jameron Jameron commented Feb 16, 2016

Added in new method for getting a person's projects list from the api.

@ricbra
Copy link
Contributor

ricbra commented Feb 16, 2016

Cool, thanks for the effort! Could you also add a test for this new method? Checkout the other tests for inspiration on how to do this. If you need help, let us know.

@Jameron
Copy link
Author

Jameron commented Feb 19, 2016

Hey I need help regarding the test setup, I started writing one using another as a reference. What is the JSON at the bottom, a sample expected response?

@ricbra
Copy link
Contributor

ricbra commented Feb 19, 2016

In the mock directory you should add a mocked response for the call you're testing. Basically it is just a response from the live basecamp api but stored as JSON. This way the tests don't depend on the Basecamp API. So, as you noticed it is indeed an expected response.

@Jameron
Copy link
Author

Jameron commented Feb 19, 2016

I added a test, the top was just copied from another test. Do I need to get that headers and stuff from Postman or Chrome Dev Tools? How are you submitting the API call? Thanks.

@ricbra
Copy link
Contributor

ricbra commented Mar 14, 2016

Sorry for the delay. This ticket went off my radar.

I copy the headers from the request which I do with the Guzzle client. It is possible to echo the response you receive from a call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants